fix(cxx_zig_toolchain): resolve wrapper paths and expand nested argsfiles #1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
cehoffman
force-pushed
the
feat/cxx-zig-toolchain-bash-source
branch
from
dcbdc56 to
9ca8eed
Compare
cehoffman
force-pushed
the
feat/cxx-zig-toolchain-bash-source
branch
from
9ca8eed to
a1cb132
Compare
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D90741556. (Because this pull request was imported automatically, there will not be any future comments.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CGO builds with zig toolchain fail because go_go_wrapper changes to a temp directory before invoking the C compiler. The generated wrapper scripts use relative paths that break once we're no longer in the project root:
After fixing that, zig also doesn't support nested argsfiles which the Go prelude generates:
This PR uses
BASH_SOURCEto resolve paths from the script's location and adds recursive argsfile expansion before invoking zig.The Windows path has the same issues but I don't have a way to test batch scripts. Would need
%~dp0for path resolution and similar expansion logic - happy to add it if someone can validate.